refactor: prepare to use the html/template version of the OSS HTML [IDE-326] #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
commented
Jun 26, 2024
| const ideStyle = readFileSync(ideStylePath.fsPath, 'utf8'); | ||
| const nonce = getNonce(); | ||
|
|
||
| // TODO: remove after the stable CLI release at the end of cycle 5 |
There was a problem hiding this comment.
Reminder to create a ticket to remove this code when we fully enable this HTML panel after the end of cycle 5 and the stable release of the CLI
There was a problem hiding this comment.
4 tasks
teodora-sandu
force-pushed
the
refactor/html-template
branch
from
8ad50d5 to
6f23814
Compare
cat2608
approved these changes
Jul 8, 2024
teodora-sandu
force-pushed
the
refactor/html-template
branch
from
6f23814 to
1f862ba
Compare
teodora-sandu
force-pushed
the
refactor/html-template
branch
from
1f862ba to
7bea9d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In snyk/snyk-ls#564 we are refactoring the HTML for OSS to use
html/templateand also to eventually be able to inject styling for IntelliJ. JCEF only supports<style>styling and not linked stylesheets so refactoring this code to work the same way it does now for Snyk Code by injecting the<style>styling into the${ideStyle}variable.We also won't need to inject the icons since they will be injected in the HTML template in LS.
We will deliver this version of VSCode for an older version of the CLI so we need to make sure it works with or without the changes in LS. So test it with and without snyk/snyk-ls#564.
Checklist